Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
jax
v0.2.21
introduced a slight breaking change,jnp.ndarray
now only returnsTrue
forjax
arrays and notnumpy
arrays. so for standardnumpy
array x,isinstance(x, jnp.ndarray)
willnow return
False
. (cf here, the last point under breaking changes)And the
jax.random.split
method returns numpy array instead of jax. We use this method during random init of the model to create therngs
dict
.Flax has a check for valid rngs where it expects
jnp.ndarray
, but sincesplit
returns np array and jax now does not treat np arrays asjnp.ndarray
the check returnsFalse
and raises an error.This has been fixed in
flax==0.3.5
(cf here). So all of our models fail withjax>=0.2.21
andflax<0.3.5
.To fix this, this PR bumps the flax version to
0.3.5
.