[testing] solve the port conflict #14362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #14331 which accidentally collapsed 2 distinct ports and the deepspeed tests started to fail.
Since
torch.distnever releases the port, those tests that run emulated launcher env never release the port (but can re-use it). But then it prevents other tests that run withpython -m torch.distributedto succeed and ending up withAddress already in useerror.I'm going to merge this to unblock the CIs (ours and Deepspeed's) since tomorrow is a holiday, but would be happy to do a follow up PR if something can be improved.
@sgugger