Raise exceptions instead of using asserts in modeling_openai #12789 #14386

nbertagnolli · 2021-11-13T22:31:15Z

What does this PR do?

Replaces control flow assertions in modeling_openai.py to address issue #12789.

Contributes to #12789

This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
Did you read the contributor guideline,
Pull Request section?
Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case. link
Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
Did you write any new necessary tests?

Tagging @sgugger I saw you commenting on the issue and some other PRs for this issue : ).

sgugger · 2021-11-14T02:34:31Z

Thanks for your help on this!

…ace#12789 (huggingface#14386) * Raise exceptions instead of using asserts for control flow in modeling_openai huggingface#12789 * reformatted file

nbertagnolli added 2 commits November 13, 2021 15:21

Raise exceptions instead of using asserts for control flow in modelin…

34250f9

…g_openai huggingface#12789

reformatted file

09a163e

sgugger merged commit 790cdc2 into huggingface:master Nov 14, 2021