Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exceptions instead of using asserts in modeling_openai #12789 #14386

Merged
merged 2 commits into from
Nov 14, 2021

Conversation

nbertagnolli
Copy link
Contributor

@nbertagnolli nbertagnolli commented Nov 13, 2021

What does this PR do?

Replaces control flow assertions in modeling_openai.py to address issue #12789.

Contributes to #12789

Before submitting

Who can review?

Tagging @sgugger I saw you commenting on the issue and some other PRs for this issue : ).

@sgugger
Copy link
Collaborator

sgugger commented Nov 14, 2021

Thanks for your help on this!

@sgugger sgugger merged commit 790cdc2 into huggingface:master Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants