Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forward method to dummy models #14419

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Add forward method to dummy models #14419

merged 2 commits into from
Nov 16, 2021

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Nov 16, 2021

What does this PR do?

This PR adds a forward/call/call method to the dummy models (depending on the framework) so that one can build the doc even if not all dependencies are present (torch-scatter in particular is annoying).

@sgugger sgugger requested a review from LysandreJik November 16, 2021 14:00
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @sgugger

@sgugger sgugger merged commit 3e8d17e into master Nov 16, 2021
@sgugger sgugger deleted the add_dummies_methods branch November 16, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants