Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitPython to quality tools #14459

Merged
merged 4 commits into from
Nov 19, 2021
Merged

Add GitPython to quality tools #14459

merged 4 commits into from
Nov 19, 2021

Conversation

LysandreJik
Copy link
Member

Adds gitpython to the quality command of the setup, as otherwise the quality tools cannot be used.

cc #14379

@LysandreJik LysandreJik requested a review from sgugger November 19, 2021 11:45
@sgugger
Copy link
Collaborator

sgugger commented Nov 19, 2021

Should we thus remove this line in the circleCI config?

            - run: pip install isort GitPython

It's there twice (code quality and repo consistency jobs).

sgugger
sgugger approved these changes Nov 19, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved of course, thanks for adding this!

@LysandreJik
Copy link
Member Author

Correct, just pushed the update. Thanks!

@LysandreJik LysandreJik merged commit 331c3d2 into master Nov 19, 2021
@LysandreJik LysandreJik deleted the LysandreJik-patch-2 branch November 19, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LysandreJik @sgugger