Doc new front github actions #14512
Merged
Doc new front github actions #14512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
reviewed
Nov 24, 2021
Comment on lines
8
to
9
| env: | ||
| HUGGINGFACE_PUSH: ${{ secrets.HUGGINGFACE_PUSH }} |
There was a problem hiding this comment.
you're not using this guy are you?
There was a problem hiding this comment.
(i mean the env var, not the secret)
There was a problem hiding this comment.
Indeed, removed! Thanks!
julien-c
reviewed
Nov 24, 2021
| run: | | ||
| git add build | ||
| git commit -m "Updated with commit ${{ github.sha }}" | ||
| git push --force origin new-branch |
There was a problem hiding this comment.
The --force (at least on the main branch) would not be desirable on the hub side as it will make maintaining a sync'd local clone of doc-builder way harder
Is the issue that you expect this workflow to run with some concurrency?
There was a problem hiding this comment.
The --force would of course be removed before merge, it's just here for testing (I'm pushing to new-branch, but I'll push to master before merging)
sgugger
approved these changes
Nov 24, 2021
| @@ -38,8 +38,9 @@ class BeitFeatureExtractor(FeatureExtractionMixin, ImageFeatureExtractionMixin): | |||
| r""" | |||
| Constructs a BEiT feature extractor. | |||
|
|
|||
| This feature extractor inherits from :class:`~transformers.FeatureExtractionMixin` which contains most of the main | |||
| methods. Users should refer to this superclass for more information regarding those methods. | |||
| This feature extractor inherits from :class:`~transformers.feature_extraction_utils.FeatureExtractionMixin` which | |||
There was a problem hiding this comment.
There are more references than this one :-)
LysandreJik
commented
Nov 24, 2021
| with: | ||
| repository: 'huggingface/doc-builder' | ||
| token: ${{ secrets.HUGGINGFACE_PUSH }} | ||
| ref: launch-script |
There was a problem hiding this comment.
This should be removed once launch-script is merged in main in doc-builder.
| run: | | ||
| git add build | ||
| git commit -m "Updated with commit ${{ github.sha }}" | ||
| # git push origin main |
There was a problem hiding this comment.
This should be uncommented
|
Doesn't have to be part of this PR. making a note here that: transformers/docs/source/versions.yml Lines 1 to 5 in 765f6a4 transformers/.circleci/deploy.sh Lines 81 to 84 in c6c0755 |
sgugger
pushed a commit
that referenced
this pull request
Dec 1, 2021
* Doc new front github actions * Fix docstring * Fix feature extraction utils import (#14515) * Address Julien's comments * Push to doc-builder * Ready for merge
sgugger
added a commit
that referenced
this pull request
Dec 1, 2021
* Convert PretrainedConfig doc to Markdown * Use syntax * Add necessary doc files (#14496) * Doc fixes (#14499) * Fixes for the new front * Convert DETR file for table * Title is needed * Simplify a bit * Even simpler * Remove imports * Fix typo in toctree (#14516) * Fix checkpoints badge * Update versions.yml format (#14517) * Doc new front github actions (#14512) * Doc new front github actions * Fix docstring * Fix feature extraction utils import (#14515) * Address Julien's comments * Push to doc-builder * Ready for merge * Remove old build and deploy * Doc misc fixes (#14583) * Rm versions.yml from doc * Fix converting.rst * Rm pretrained_models from toctree * Fix index links (#14567) * Fix links in README * Localized READMEs * Fix copy script * Fix find doc script * Update README_ko.md Co-authored-by: Julien Chaumond <julien@huggingface.co> Co-authored-by: Julien Chaumond <julien@huggingface.co> * Adapt build command to new CLI tools (#14578) * Fix typo * Fix doc interlinks (#14589) * Convert PretrainedConfig doc to Markdown * Use syntax * Rm pattern <[a-z]+(.html).*> * Rm huggingface.co/transformers/master * Rm .html * Rm .html from index.mdx * Rm .html from model_summary.rst * Update index.mdx rm html * Update remove .html * Fix inner doc links * Fix interlink in preprocssing.rst * Update pr_checks Co-authored-by: Sylvain Gugger <sylvain.gugger@gmail.com> Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Convert PretrainedConfig doc to Markdown * Use syntax * Add necessary doc files (#14496) * Doc fixes (#14499) * Fixes for the new front * Convert DETR file for table * Title is needed * Simplify a bit * Even simpler * Remove imports * Fix checkpoints badge * Fix typo in toctree (#14516) * Update versions.yml format (#14517) * Doc new front github actions (#14512) * Doc new front github actions * Fix docstring * Fix feature extraction utils import (#14515) * Address Julien's comments * Push to doc-builder * Ready for merge * Remove old build and deploy * Doc misc fixes (#14583) * Rm versions.yml from doc * Fix converting.rst * Rm pretrained_models from toctree * Fix index links (#14567) * Fix links in README * Localized READMEs * Fix copy script * Fix find doc script * Update README_ko.md Co-authored-by: Julien Chaumond <julien@huggingface.co> Co-authored-by: Julien Chaumond <julien@huggingface.co> * Adapt build command to new CLI tools (#14578) * Fix typo * Fix doc interlinks (#14589) * Convert PretrainedConfig doc to Markdown * Use syntax * Rm pattern <[a-z]+(.html).*> * Rm huggingface.co/transformers/master * Rm .html * Rm .html from index.mdx * Rm .html from model_summary.rst * Update index.mdx rm html * Update remove .html * Fix inner doc links * Fix interlink in preprocssing.rst * Update pr_checks Co-authored-by: Sylvain Gugger <sylvain.gugger@gmail.com> Co-authored-by: Sylvain Gugger <35901082+sgugger@users.noreply.github.com> * Styling Co-authored-by: Mishig Davaadorj <mishig.davaadorj@coloradocollege.edu> Co-authored-by: Lysandre Debut <lysandre@huggingface.co> Co-authored-by: Julien Chaumond <julien@huggingface.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New doc builder.
Before merging, will only need to change the branch name to which the script pushes.