Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Dataset for TQA + token-classification. #14658

Merged
merged 3 commits into from
Dec 8, 2021

Conversation

Narsil
Copy link
Contributor

@Narsil Narsil commented Dec 7, 2021

What does this PR do?

Fixes #14301
Fixes TQA tests to actually decouple TF and PT (some TF tests need PT, but not the other way around, if we have all requirements, basically no test ever get run by automated tests.)
Enable Dataset with TQA too.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil Narsil requested a review from LysandreJik December 7, 2021 14:19
Comment on lines +44 to +47
@require_tensorflow_probability
@require_pandas
@require_tf
@require_torch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it, @Narsil

@Narsil Narsil merged commit 2e12d90 into huggingface:master Dec 8, 2021
@Narsil Narsil deleted the fix_piping_token_classification branch December 8, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants