Skip to content

Conversation

Narsil
Copy link
Contributor

@Narsil Narsil commented Jan 3, 2022

What does this PR do?

Backward compatibility broken in
#14988

This restabilishes the correct outputs.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Backward compatibility broken in
huggingface#14988
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @Narsil!

@Narsil Narsil merged commit 8c2618e into huggingface:master Jan 3, 2022
@Narsil Narsil deleted the list_input_t2t branch January 3, 2022 13:50
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants