Skip to content

[Fix doc example] - OpenAIGPTDoubleHeadsModel #15143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2022
Merged

[Fix doc example] - OpenAIGPTDoubleHeadsModel #15143

merged 1 commit into from
Jan 14, 2022

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Jan 13, 2022 •
edited
Loading

What does this PR do?

This line fails

transformers/src/transformers/models/openai/modeling_openai.py

Line 690 in 7b83feb

>>> lm_logits = outputs.lm_logits

Should change from lm_logits to logits (See OpenAIGPTDoubleHeadsModelOutput)

Who can review

@patrickvonplaten, @LysandreJik

patil-suraj
patil-suraj approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the fix!

@patil-suraj patil-suraj merged commit 4aa16fc into huggingface:master Jan 14, 2022
@ydshieh ydshieh deleted the fix_doc_example_018 branch January 14, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@patil-suraj patil-suraj patil-suraj approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydshieh @patil-suraj