Skip to content

Add FastTokenizer to REALM #15211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 19, 2022
Merged

Add FastTokenizer to REALM #15211

merged 6 commits into from
Jan 19, 2022

Conversation

qqaatw
Copy link
Contributor

@qqaatw qqaatw commented Jan 18, 2022 •
edited
Loading

What does this PR do?

This is a follow-up PR of #13292 (comment) and #13292 (comment).

This PR removes the BertTokenizer abstraction and adds a FastTokenizer to REALM.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@patrickvonplaten @patil-suraj @sgugger

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qqaatw qqaatw marked this pull request as ready for review January 19, 2022 12:33
@qqaatw qqaatw mentioned this pull request Jan 19, 2022
Merged
patil-suraj
patil-suraj approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@patil-suraj patil-suraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank your for adding the fast version.

src/transformers/models/realm/configuration_realm.py
Comment on lines +24 to +31
"qqaatw/realm-cc-news-pretrained-embedder": "https://huggingface.co/qqaatw/realm-cc-news-pretrained-embedder/resolve/main/config.json",
"qqaatw/realm-cc-news-pretrained-encoder": "https://huggingface.co/qqaatw/realm-cc-news-pretrained-encoder/resolve/main/config.json",
"qqaatw/realm-cc-news-pretrained-scorer": "https://huggingface.co/qqaatw/realm-cc-news-pretrained-scorer/resolve/main/config.json",
"qqaatw/realm-cc-news-pretrained-openqa": "https://huggingface.co/qqaatw/realm-cc-news-pretrained-openqa/aresolve/main/config.json",
"qqaatw/realm-orqa-nq-openqa": "https://huggingface.co/qqaatw/realm-orqa-nq-openqa/resolve/main/config.json",
"qqaatw/realm-orqa-nq-reader": "https://huggingface.co/qqaatw/realm-orqa-nq-reader/resolve/main/config.json",
"qqaatw/realm-orqa-wq-openqa": "https://huggingface.co/qqaatw/realm-orqa-wq-openqa/resolve/main/config.json",
"qqaatw/realm-orqa-wq-reader": "https://huggingface.co/qqaatw/realm-orqa-wq-reader/resolve/main/config.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to this PR:
but these checkpoints should be under google org since the model is released by google.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @qqaatw actually trained the model himself no?

So guess in this case it's ok to leave it under your name :-)

Copy link
Contributor Author

@qqaatw qqaatw Jan 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These checkpoints were trained by Google in TF, and I converted them to PyTorch and validated their effectiveness, which is the benchmarking results previously shown.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can however fine-tune on my side, but we should first upload block_records.npy to qqaatw/realm-cc-news-pretrained-openqa so that I'm able to do it with the latest RealmRetriever.from_pretrained API.

sgugger
sgugger approved these changes Jan 19, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding this!

@patil-suraj patil-suraj merged commit 841d979 into huggingface:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten left review comments

@patil-suraj patil-suraj patil-suraj approved these changes

@sgugger sgugger sgugger approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qqaatw @patrickvonplaten @patil-suraj @sgugger