Skip to content

🌐 [i18n-KO] Translated clipseg.md to Korean #39903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 12, 2025
Merged

🌐 [i18n-KO] Translated clipseg.md to Korean #39903

merged 4 commits into from
Sep 12, 2025

Conversation

HyunZ118
Copy link
Contributor

@HyunZ118 HyunZ118 commented Aug 5, 2025

What does this PR do?

Translated the clipseg.md file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

May you please review this PR?
@4N3MONE, @Kim-Ju-won, @ahnjj, @FacerAin, @ssum21, @TaskerJang

Before submittin

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

Kim-Ju-won
Kim-Ju-won reviewed Aug 8, 2025
View reviewed changes
Copy link
Contributor

@Kim-Ju-won Kim-Ju-won left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 제 기준에서는 완벽한 번역이라고 느껴졌습니다 😊
개인적으로는 초록을 번역할 때 어색하게 느껴지는 경우가 종종 있었는데,
이번 문단에서는 전혀 번역체 느낌 없이 자연스럽게 읽혀서 인상 깊게 남았네요!

Glossary 기준에 따라 몇 가지 표현만 조심스럽게 제안드렸는데요,
그럼에도 불구하고 기존 표현이 원문 뉘앙스를 더 잘 살린 걸 수도 있을 것 같아서
다른 리뷰어 분들의 의견도 함께 들어보면 좋겠다는 생각이 들었습니다!

TaskerJang
TaskerJang reviewed Aug 9, 2025
View reviewed changes
docs/source/ko/model_doc/clipseg.md Outdated
## 사용 팁[[usage-tips]]

- [`CLIPSegForImageSegmentation`]은 [`CLIPSegModel`]과 동일한, [`CLIPSegModel`] 위에 디코더를 추가한 모델입니다.
- [`CLIPSegForImageSegmentation`]은 테스트 시점에 임의의 프롬프트를 기반으로 이미지 분할을 생성합니다. 이떄 프롬프트는 텍스트(`input_ids`), 이미지(`conditional_pixel_values`), 또는 사용자 정의 조건부 임베딩(`conditional_embeddings`)을 사용할 수 있습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"이떄" → "이때"로 맞춤법 수정이 필요합니다.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세 가지 항목이 연결되는 구조이므로 쉼표를 맞추면 더 깔끔할거 같습니다! 예: "텍스트(input_ids), 이미지(conditional_pixel_values), 사용자 정의 조건부 임베딩(conditional_embeddings)"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현상님, 피드백 감사드립니다!
제안 주신 내용 모두 수정 완료하였습니다 🙂

HyunZ118
HyunZ118 commented Aug 9, 2025
View reviewed changes
@HyunZ118 @Kim-Ju-won
Apply suggestions from code review
54e4aed 
Co-authored-by: Kim Juwon <81630351+Kim-Ju-won@users.noreply.github.com>
@HyunZ118
Copy link
Contributor Author

HyunZ118 commented Aug 9, 2025

LGTM! 제 기준에서는 완벽한 번역이라고 느껴졌습니다 😊 개인적으로는 번역할 때 “초록”이라는 표현이 어색하게 느껴지는 경우가 종종 있었는데, 이번 문단에서는 전혀 번역체 느낌 없이 자연스럽게 읽혀서 인상 깊었어요.

Glossary 기준에 따라 몇 가지 표현만 조심스럽게 제안드렸는데요, 그럼에도 불구하고 기존 표현이 원문 뉘앙스를 더 잘 살린 걸 수도 있을 것 같아서 다른 리뷰어 분들의 의견도 함께 들어보면 좋겠다는 생각이 들었습니다!

극찬 감사드립니다🙇🏻
'초록' 부분을 번역할 때 여러번 수정하였는데 자연스럽게 읽혔다니 기분이 좋고 뿌듯합니다!
꼼꼼하게 리뷰해주셔서 다시 한번 감사드립니다!

@Kim-Ju-won
Copy link
Contributor

Kim-Ju-won commented Aug 9, 2025 •
edited
Loading

@HyunZ118
Thanks so much for incorporating the glossary suggestions!
I really appreciate the care you put into aligning the terms with our official glossary—it makes the translation feel consistent and polished.
Great work wrapping this up so smoothly! 😊
LGTM 👍

@TaskerJang
Copy link
Contributor

@HyunZ118
피드백 반영해주신 부분 잘 확인했습니다 👍
맞춤법과 문장 구조가 모두 깔끔하게 정리되어 읽기 훨씬 매끄러워졌습니다.
세심한 수정과 빠른 반영 감사드리며, LGTM입니다 🚀

4N3MONE
4N3MONE approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@4N3MONE 4N3MONE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 번역 고생하셨습니다! 🤗

@HyunZ118 HyunZ118 marked this pull request as ready for review September 11, 2025 07:00
@HyunZ118
Copy link
Contributor Author

@stevhliu
May you review this PR please?🙏🏻

stevhliu
stevhliu approved these changes Sep 11, 2025
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution! 🤗

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu
Copy link
Member

build-doc

@github-actions GitHub Actions
Copy link
Contributor

Building docs for all languages...

@stevhliu stevhliu merged commit c81f426 into huggingface:main Sep 12, 2025
16 checks passed
vijayabhaskar-ev pushed a commit to vijayabhaskar-ev/transformers that referenced this pull request Oct 2, 2025
@HyunZ118 @Kim-Ju-won @vijayabhaskar-ev
🌐 [i18n-KO] Translated clipseg.md to Korean (huggingface#39903)
518844e 
* docs: ko: model_doc/clipseg.md

* fix: manual edits

* Apply suggestions from code review

Co-authored-by: Kim Juwon <81630351+Kim-Ju-won@users.noreply.github.com>

---------

Co-authored-by: Kim Juwon <81630351+Kim-Ju-won@users.noreply.github.com>
yuchenxie4645 pushed a commit to yuchenxie4645/transformers that referenced this pull request Oct 4, 2025
@HyunZ118 @Kim-Ju-won @yuchenxie4645
🌐 [i18n-KO] Translated clipseg.md to Korean (huggingface#39903)
208b885 
* docs: ko: model_doc/clipseg.md

* fix: manual edits

* Apply suggestions from code review

Co-authored-by: Kim Juwon <81630351+Kim-Ju-won@users.noreply.github.com>

---------

Co-authored-by: Kim Juwon <81630351+Kim-Ju-won@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevhliu stevhliu stevhliu approved these changes

+3 more reviewers

@4N3MONE 4N3MONE 4N3MONE approved these changes

@Kim-Ju-won Kim-Ju-won Kim-Ju-won approved these changes

@TaskerJang TaskerJang TaskerJang approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@HyunZ118 @Kim-Ju-won @TaskerJang @HuggingFaceDocBuilderDev @stevhliu @4N3MONE