Skip to content

remove FSDP prefix when using save_pretrained with FSDP2 #40207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2025
Merged

remove FSDP prefix when using save_pretrained with FSDP2 #40207

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
285deda
remove FSDP prefix when using save_pretrained with FSDP2
winglian Aug 15, 2025
ceaca6d
Merge branch 'main' into fsdp2-model-name-save
S1ro1 Aug 19, 2025
26f0e7a
Merge branch 'main' into fsdp2-model-name-save
S1ro1 Sep 8, 2025
aa5cf7e
Fix: use removeprefix correctly
S1ro1 Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/transformers/modeling_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4022,7 +4022,8 @@ def save_pretrained(
model_to_save.config.dtype = str(dtype).split(".")[1]

# Attach architecture to the config
model_to_save.config.architectures = [model_to_save.__class__.__name__]
# When using FSDP2, unwrapping is a noop, so the model name doesn't change back to the original model name
model_to_save.config.architectures = [model_to_save.__class__.__name__.removeprefix("FSDP")]

# If we have a custom model, we copy the file defining it in the folder and set the attributes so it can be
# loaded from the Hub.
Expand Down