Fix crash when executing MambaCache sample code #40557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torotoki
changed the title
torotoki
changed the title
torotoki
force-pushed
the
bugfix-with-mamba-cache-position
branch
from
20e4166 to
5b1c9c1
Compare
torotoki
changed the title
torotoki
changed the title
|
cc @gante @zucchini-nlp since this is based on cache updates |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
gante
reviewed
Sep 5, 2025
| >>> cache_position = torch.arange(len(inputs["input_ids"][0]), device=model.device) # sequence length | ||
| >>> outputs = model(**inputs, cache_params=cache_params, cache_position=cache_position, use_cache=True) | ||
| >>> outputs.cache_params | ||
| FalconMambaCache() |
There was a problem hiding this comment.
(this is not the output, let's remove this line too)
| >>> cache_position = torch.arange(len(inputs["input_ids"][0]), device=model.device) # sequence length | ||
| >>> outputs = model(**inputs, cache_params=cache_params, cache_position=cache_position, use_cache=True) | ||
| >>> outputs.cache_params | ||
| MambaCache() |
torotoki
force-pushed
the
bugfix-with-mamba-cache-position
branch
2 times, most recently
from
4ef40ff to
18df233
Compare
torotoki
force-pushed
the
bugfix-with-mamba-cache-position
branch
from
18df233 to
8a979c1
Compare
gante
approved these changes
Sep 9, 2025
|
[For maintainers] Suggested jobs to run (before merge) run-slow: falcon_mamba, mamba |
|
Thanks for following up! |
vijayabhaskar-ev
pushed a commit
to vijayabhaskar-ev/transformers
that referenced
this pull request
Oct 2, 2025
* Fix the sample code of MambaCache * Update automatically generated code * Fix FalconMambaCache documents * minor doc fixes --------- Co-authored-by: Joao Gante <joao@huggingface.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the obsolete sample code of
MambaCachethat does not work.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.