Skip to content

Conversation

voidism
Copy link
Contributor

@voidism voidism commented Aug 30, 2025

What does this PR do?

The new model support for MetaCLIP 2 is done, but the documentation is with the wrong links and wrong model names.
The issue is already mentioned by @howardhsu in #39826 (comment)_

just realized the example code in the documentation has invalid path openai/metaclip_2-vit-base-patch32, should be facebook/metaclip-2-worldwide-huge-quickgelu ?

@NielsRogge tried to fix it in #39826 (comment)_ but it seems not trivial to fix because the modular model converter caused it.

Also, as mentioned by @ArthurZucker in #39826 (comment)_

You can probably just overwrite the full docstring for now, there are no better solutions I think

I just finished exactly what @ArthurZucker suggested to overwrite the full docstring! 🤗

I didn't modify any functionality other than the docstrings.

Fixes #39826

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker @howardhsu @NielsRogge

Documentation: @stevhliu

Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: metaclip_2

@voidism
Copy link
Contributor Author

voidism commented Sep 2, 2025

Hi @NielsRogge !

I am the first author of MetaCLIP 2, and I just wanted to fix some errors on the model names in the documentation of MetaCLIP 2. Can you help me on reviewing this PR? Thanks so much!

@Rocketknight1
Copy link
Member

run-slow: metaclip_2

Copy link
Contributor

github-actions bot commented Sep 3, 2025

This comment contains run-slow, running the specified jobs:

models: ['models/metaclip_2']
quantizations: [] ...

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @voidism, sorry for the delay! I'm happy to approve this one quickly - the links are clearly broken in the existing code. If the relevant maintainers have any issues, they can ping me here when they get back and I can open a follow-up PR to fix it.

@Rocketknight1 Rocketknight1 merged commit 5e2e496 into huggingface:main Sep 3, 2025
15 checks passed
@voidism
Copy link
Contributor Author

voidism commented Sep 3, 2025

Hi @Rocketknight1 –it looks great to me! Thanks a lot for your help!

@NielsRogge
Copy link
Contributor

Thanks @voidism for taking this up!

@voidism
Copy link
Contributor Author

voidism commented Sep 3, 2025

@NielsRogge Thank you for integrating MetaCLIP 2 into HF!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants