Skip to content

Mark LongformerModelTest::test_attention_outputs as flaky #40655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2025
Merged

Mark LongformerModelTest::test_attention_outputs as flaky #40655

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b207195
fix
ydshieh Sep 3, 2025
1bf4ac0
fix
ydshieh Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion tests/models/longformer/test_modeling_longformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,14 @@
import unittest

from transformers import LongformerConfig, is_torch_available
from transformers.testing_utils import require_sentencepiece, require_tokenizers, require_torch, slow, torch_device
from transformers.testing_utils import (
is_flaky,
require_sentencepiece,
require_tokenizers,
require_torch,
slow,
torch_device,
)

from ...test_configuration_common import ConfigTester
from ...test_modeling_common import ModelTesterMixin, ids_tensor, random_attention_mask
Expand Down Expand Up @@ -355,6 +362,14 @@ def setUp(self):
self.model_tester = LongformerModelTester(self)
self.config_tester = ConfigTester(self, config_class=LongformerConfig, hidden_size=37)

# Without this, 0.01% failure rate.
@is_flaky(
max_attempts=2,
description="When `inputs_dict['attention_mask'][:, -1]` is all `0`s, we get shorter length along the last dimension of the output's `attentions`.",
)
def test_attention_outputs(self):
super().test_attention_outputs()

def test_config(self):
self.config_tester.run_common_tests()

Expand Down