Skip to content

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Sep 4, 2025

What does this PR do?

Add Optional to more types, these are not detected by ruff.
The incorrect typing was found by

grep ': [^:=O|N,]*= *None' -r src/transformers | grep -v tf | grep -v flax | more

The changes were generated by the following commands:

sed -i -e 's/: AudioInput = None/: Optional[AudioInput] = None/g' src/transformers/**/*py
sed -i -e 's/: torch.BoolTensor = None/: Optional[torch.BoolTensor] = None/g' src/transformers/**/*py
sed -i -e 's/: torch.int32 = None/: Optional[torch.int32] = None/g' src/transformers/**/*py
sed -i -e 's/: AutoConfig = None/: Optional[AutoConfig] = None/g' src/transformers/**/*py
sed -i -e 's/: VideoInput = None/: Optional[VideoInput] = None/g' src/transformers/**/*py
sed -i -e 's/: ImageInput = None/: Optional[ImageInput] = None/g' src/transformers/**/*py
sed -i -e 's/: list\[int\] = None/: Optional[list[int]] = None/g' src/transformers/**/*py
sed -i -e 's/: list\[int\] = None/: Optional[list[int] = None/g' src/transformers/**/*py
sed -i -e 's/: str = None/: Optional[str] = None/g' src/transformers/**/*py
sed -i -e 's/: float = None/: Optional[float] = None/g' src/transformers/**/*py
sed -i -e 's/: torch.dtype = None/: Optional[torch.dtype] = None/g' src/transformers/**/*py
sed -i -e 's/: torch.device = None/: Optional[torch.device] = None/g' src/transformers/**/*py
sed -i -e 's/: torch.Tensor = None/: Optional[torch.Tensor] = None/g' src/transformers/**/*py
sed -i -e 's/: int = None/: Optional[int] = None/g' src/transformers/**/*py
sed -i -e 's/: torch.FloatTensor = None/: Optional[torch.FloatTensor] = None/g' src/transformers/**/*py
sed -i -e 's/: PILImageResampling = None/: Optional[PILImageResampling] = None/g' src/transformers/**/*py
sed -i -e 's/: torch.LongTensor = None/: Optional[torch.LongTensor] = None/g' src/transformers/**/*py
sed -i -e 's/: "F.InterpolationMode" = None/: Optional["F.InterpolationMode"] = None/g' src/transformers/**/*py
sed -i -e 's/: tuple\[torch.FloatTensor\] = None/: Optional[tuple[torch.FloatTensor]] = None/g' src/transformers/**/*py
sed -i -e 's/: list\[torch.FloatTensor\] = None/: Optional[list[torch.FloatTensor]] = None/g' src/transformers/**/*py
sed -i -e 's/: HybridMambaAttentionDynamicCache = None/: Optional[HybridMambaAttentionDynamicCache] = None/g' s
rc/transformers/**/*py
sed -i -e 's/: dict = None/: Optional[dict] = None/g' src/transformers/**/*py
sed -i -e 's/: ChannelDimension = None/: Optional[ChannelDimension] = None/g' src/transformers/**/*py
sed -i -e 's/: "F.InterpolationMode" = None/: Optional["F.InterpolationMode"] = None/g' src/transformers/**/*py

There were also two or three manual fixes.
TF and Flax code are skipped for obvious reasons.

@cyyever cyyever force-pushed the improve_typing10 branch 11 times, most recently from 12bb3ca to d2d573a Compare September 5, 2025 00:39
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with a couple of small nits! It might also need a rebase because of conflicts

@cyyever
Copy link
Contributor Author

cyyever commented Sep 5, 2025

@Rocketknight1 All are fixed.

Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
@Rocketknight1 Rocketknight1 enabled auto-merge (squash) September 5, 2025 13:46
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

github-actions bot commented Sep 5, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: align, altclip, aria, aya_vision, bart, beit, bigbird_pegasus, bit, blip, blip_2, bridgetower, chameleon, chinese_clip, clip, cohere2_vision, colpali

@Rocketknight1 Rocketknight1 merged commit 828044c into huggingface:main Sep 5, 2025
23 checks passed
@cyyever cyyever deleted the improve_typing10 branch September 6, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants