-
Notifications
You must be signed in to change notification settings - Fork 30.6k
Add Optional typing #40686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Optional typing #40686
Conversation
12bb3ca
to
d2d573a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, with a couple of small nits! It might also need a rebase because of conflicts
d2d573a
to
27efe90
Compare
@Rocketknight1 All are fixed. |
Signed-off-by: cyy <cyyever@outlook.com>
Signed-off-by: cyy <cyyever@outlook.com>
9df56df
to
ac4ea1b
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
[For maintainers] Suggested jobs to run (before merge) run-slow: align, altclip, aria, aya_vision, bart, beit, bigbird_pegasus, bit, blip, blip_2, bridgetower, chameleon, chinese_clip, clip, cohere2_vision, colpali |
What does this PR do?
Add Optional to more types, these are not detected by ruff.
The incorrect typing was found by
The changes were generated by the following commands:
There were also two or three manual fixes.
TF and Flax code are skipped for obvious reasons.