Skip to content

Conversation

framonmar7
Copy link
Contributor

What does this PR do?

This PR fixes a repeated bug across several image processor classes (ConditionalDetrImageProcessorFast, DeformableDetrImageProcessorFast, GroundingDinoImageProcessorFast, Mask2FormerImageProcessorFast, and RTDetrImageProcessorFast).

Several post_process* methods were defined without a self parameter, which would raise a TypeError when called from an object instance.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Vision models: @amyeroberts, @qubvel

Copy link
Contributor

github-actions bot commented Sep 5, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: conditional_detr, deformable_detr, grounding_dino, mask2former, rt_detr

Copy link
Contributor

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I will merge this PR. However, for reference, it's not actually a bug because modular files are not executable files. This is actually a definition to remove these methods in the converted modeling file, so there is no effect on the actual code.

@qubvel qubvel enabled auto-merge (squash) September 5, 2025 10:45
@qubvel qubvel merged commit f3211b5 into huggingface:main Sep 5, 2025
14 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@framonmar7 framonmar7 deleted the fix/add-self-to-post-process-methods branch September 5, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants