🔴 Update Glm4V to use config values #40712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run-slow: glm4v, glm4v_moe |
|
This comment contains run-slow, running the specified jobs: models: ['models/glm4v', 'models/glm4v_moe'] |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
The tests are same as failing on main, though one model is failng always. No idea how it was working up to now, will just fix the defaults to make it run |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: glm4v |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As discussed earlier, we should use config values which authors confirmed are correct. Kinda breaking, so marking it with 🔴
Probably will need update slow tests as well, let's see what CI says