Skip to content

Conversation

liangel-02
Copy link
Contributor

@liangel-02 liangel-02 commented Sep 9, 2025

Summary

Renaming get_state_dict() method in hf_quantizer to get_state_dict_and_metadata() and updating functionality to return metadata along with state_dict.

This reduces confusion related to enabling torchao safetensor support built out in this PR.

Test Plan

python -m pytest ./tests/quantization

@liangel-02 liangel-02 force-pushed the rename_fn branch 2 times, most recently from ee90575 to b171b2d Compare September 9, 2025 19:12
@liangel-02 liangel-02 marked this pull request as ready for review September 9, 2025 19:15
@liangel-02 liangel-02 force-pushed the rename_fn branch 2 times, most recently from b15033e to 9e5d89e Compare September 9, 2025 19:18
@liangel-02 liangel-02 marked this pull request as draft September 9, 2025 19:25
@liangel-02 liangel-02 marked this pull request as ready for review September 9, 2025 19:51
@Rocketknight1
Copy link
Member

cc @SunMarc

@jerryzh168
Copy link
Contributor

cc @MekkCyber @SunMarc please take a look again

Copy link
Contributor

@MekkCyber MekkCyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🤗 LGTM

@liangel-02
Copy link
Contributor Author

@MekkCyber do you mind merging this? thanks!

Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: mxfp4

@MekkCyber
Copy link
Contributor

Hi @liangel-02 ! will merge when the ci finishes 🤗

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@MekkCyber MekkCyber merged commit f6999b0 into huggingface:main Sep 17, 2025
23 checks passed
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

ErfanBaghaei pushed a commit to ErfanBaghaei/transformers that referenced this pull request Sep 25, 2025
…0774)

renaming get_state_dict function

Co-authored-by: Mohamed Mekkouri <93391238+MekkCyber@users.noreply.github.com>
vijayabhaskar-ev pushed a commit to vijayabhaskar-ev/transformers that referenced this pull request Oct 2, 2025
…0774)

renaming get_state_dict function

Co-authored-by: Mohamed Mekkouri <93391238+MekkCyber@users.noreply.github.com>
yuchenxie4645 pushed a commit to yuchenxie4645/transformers that referenced this pull request Oct 4, 2025
…0774)

renaming get_state_dict function

Co-authored-by: Mohamed Mekkouri <93391238+MekkCyber@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants