Align torch implementation of Gated DeltaNet in Qwen3-Next with fla library. #40807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyrilvallez
reviewed
Sep 11, 2025
Comment on lines
449
to
450
| head_dim = query.size(-1) | ||
| inv_scale = torch.rsqrt(torch.tensor(head_dim, device=query.device, dtype=query.dtype)) |
There was a problem hiding this comment.
I think it would be easier to read if we keep it as a scalar as we usually do in the Attention modules 🤗
inv_scale = query.size(-1)**-0.5
added 2 commits
September 11, 2025 18:09
|
[For maintainers] Suggested jobs to run (before merge) run-slow: qwen3_next |
vijayabhaskar-ev
pushed a commit
to vijayabhaskar-ev/transformers
that referenced
this pull request
Oct 2, 2025
…ibrary. (huggingface#40807) * align torch implementation of gdn with fla. * fix fla import. * fix * remove unused attr * fixes --------- Co-authored-by: bozheng-hit <dsoul0621@gmail.com> Co-authored-by: Cyril Vallez <cyril.vallez@gmail.com>
yuchenxie4645
pushed a commit
to yuchenxie4645/transformers
that referenced
this pull request
Oct 4, 2025
…ibrary. (huggingface#40807) * align torch implementation of gdn with fla. * fix fla import. * fix * remove unused attr * fixes --------- Co-authored-by: bozheng-hit <dsoul0621@gmail.com> Co-authored-by: Cyril Vallez <cyril.vallez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to align the PyTorch implementation of Gated DeltaNet in Qwen3-Next with the corresponding implementation in the fla library, ensuring consistency between the two implementations.