-
Notifications
You must be signed in to change notification settings - Fork 30.7k
remove dummy EncodingFast #40864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dummy EncodingFast #40864
Conversation
bf3d8a5
to
1b5eaef
Compare
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
1b5eaef
to
4c0c295
Compare
If we don't have a dummy class for the type hint, do we need |
@Rocketknight1 Note that it is imported when |
Yes, I get that! I'm just wondering what happens if a user doesn't have |
@Rocketknight1 It will not affect slow tokenization. At the worst case the linters say an unknown type, like (I deliberately uninstalled
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, okay. Seems safe in that case. Thank you for the PR!
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
What does this PR do?
Remove the dummy EncodingFast class. It's safer to always use the real EncodingFast.