Skip to content

Conversation

Cyrilvallez
Copy link
Member

@Cyrilvallez Cyrilvallez commented Sep 15, 2025

What does this PR do?

As per the title. As it's only used internally in the Caches, it does not necessarily needs a deprecation cycle where we keep the old names IMO. We can however do it, will let you judge @ArthurZucker

cc @gante and @manueldeprada as well, we talked about it before!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this is probably gonna be the first PR for v5 as it is breaking 🤣

@Cyrilvallez
Copy link
Member Author

Added BC classes to avoid friction! Should be ready to go now!

@Cyrilvallez Cyrilvallez merged commit 3688a97 into main Sep 16, 2025
24 checks passed
@Cyrilvallez Cyrilvallez deleted the better-names branch September 16, 2025 10:14
ErfanBaghaei pushed a commit to ErfanBaghaei/transformers that referenced this pull request Sep 25, 2025
* unify naming

* style

* doc as well

* post rebase fix

* style

* style

* revert
vijayabhaskar-ev pushed a commit to vijayabhaskar-ev/transformers that referenced this pull request Oct 2, 2025
* unify naming

* style

* doc as well

* post rebase fix

* style

* style

* revert
yuchenxie4645 pushed a commit to yuchenxie4645/transformers that referenced this pull request Oct 4, 2025
* unify naming

* style

* doc as well

* post rebase fix

* style

* style

* revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants