Skip to content

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Sep 16, 2025

What does this PR do?

This model has "do_sample": true, in its generation_config.json, see

https://huggingface.co/zai-org/GLM-4.1V-9B-Thinking/blob/main/generation_config.json

We need to set seed, otherwise I will have nightmare of getting different outputs each day ... 😭

Glm4vIntegrationTest now all pass

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: glm4v

Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I wonder how these tests were passing prev. Btw, we can just set sampling to False as well right?

@ydshieh
Copy link
Collaborator Author

ydshieh commented Sep 16, 2025

I wonder how these tests were passing prev.

Never pass I think, or just pass from time to time (got lucky during the sampling).

Btw, we can just set sampling to False as well right?

Yes

@ydshieh ydshieh merged commit 65f9ede into main Sep 16, 2025
18 checks passed
@ydshieh ydshieh deleted the fix_glm4v branch September 16, 2025 11:01
ErfanBaghaei pushed a commit to ErfanBaghaei/transformers that referenced this pull request Sep 25, 2025
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
vijayabhaskar-ev pushed a commit to vijayabhaskar-ev/transformers that referenced this pull request Oct 2, 2025
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
yuchenxie4645 pushed a commit to yuchenxie4645/transformers that referenced this pull request Oct 4, 2025
* fix

* fix

* fix

---------

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants