Don't list dropout in eager_paged_attention_forward #40924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyyever
force-pushed
the
dropout_atten
branch
2 times, most recently
from
c940b1b to
e170575
Compare
|
cc @Cyrilvallez for attention change |
|
Hey! This change does not make sense, paged attention is inference-only (tightly coupled to the Cache)! We never use dropout during inference! |
|
@Cyrilvallez That is quite reasonable, so we should ignore |
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
cyyever
force-pushed
the
dropout_atten
branch
from
e170575 to
f2c8a30
Compare
cyyever
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ErfanBaghaei
pushed a commit
to ErfanBaghaei/transformers
that referenced
this pull request
Sep 25, 2025
Remove dropout argument Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
vijayabhaskar-ev
pushed a commit
to vijayabhaskar-ev/transformers
that referenced
this pull request
Oct 2, 2025
Remove dropout argument Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
yuchenxie4645
pushed a commit
to yuchenxie4645/transformers
that referenced
this pull request
Oct 4, 2025
Remove dropout argument Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
dropoutargument is not used in eager_paged_attention_forward.