Minor fix for #40727 #40929
Merged
Minor fix for #40727 #40929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Sep 17, 2025
|
|
||
| # The frame that calls this patched method (it may not be the test method) | ||
| # -1: `_get_test_info`; -2: `patched_xxx`; -3: the caller to `patched_xxx` | ||
| caller_frame = stack[-3] |
There was a problem hiding this comment.
This was a bit hardcoded, and it turns out that this causes issue when @require_read_token is applied to a test class, where we will get
stack[-1]: _get_test_info
stack[-2]: patched
stack[-3]: wrapper (from def require_read_token)
stack[-4]: the caller to the method that is wrapped (in this case, it's self.assertEqual)
There was a problem hiding this comment.
Example is
FAILED tests/models/mistral/test_modeling_mistral.py::MistralIntegrationTest::test_speculative_generation - TypeError: 'NoneType' object is not subscriptable
where we have
@require_read_token
class MistralIntegrationTest(unittest.TestCase):
ydshieh
commented
Sep 17, 2025
Comment on lines
+3499
to
+3500
| if origin_method_being_patched.__name__ in frame.line: | ||
| caller_frame = frame |
There was a problem hiding this comment.
In this PR, we check against the name of the original method being patched.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ahadnagy
approved these changes
Sep 17, 2025
ErfanBaghaei
pushed a commit
to ErfanBaghaei/transformers
that referenced
this pull request
Sep 25, 2025
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
vijayabhaskar-ev
pushed a commit
to vijayabhaskar-ev/transformers
that referenced
this pull request
Oct 2, 2025
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
yuchenxie4645
pushed a commit
to yuchenxie4645/transformers
that referenced
this pull request
Oct 4, 2025
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?