Update WPCS to 2.1.0

[mikeselander]

We recently bumped WPCS to 1.2.1, but it took so long that they've now released a version 2.1.0. We should probably look at bumping that version up for our standards.

[ntwb]

FYI: WPCS 2.1 is planned for release April 8th (this coming Monday)

[mikeselander]

Thanks for the FYI @ntwb, updated 👍

[mikeselander]

Noting that VIPCS conflicts with WPCS 2.*, which would affect our ability to upgrade. It looks like the VIPCS team is working on compatibility but there's no promise when it would be ready: https://github.com/Automattic/VIP-Coding-Standards/milestone/4

[spacedmonkey]

At the same time as looking into this, you will likely need VIP-Coding-Standards to 1.0.0 . See #136

[spacedmonkey]

Any plans for this?

[mikeselander]

@spacedmonkey we will definitely upgrade to this at some point, but we're not in a rush here. These upgrades tend to break existing expectations on current projects so we take them pretty slowly. Additionally there is a dependency on VIPCS updating their code to work with 2.* of WPCS so we won't even consider this until that's fixed.

That being said, if someone else has the time to look into and consider regressions that might come from the 1.2 -> 2.1 upgrade we're always accepting PRs!

[spacedmonkey]

Now that VIP GO coding standard is compatible with VIP GO standard 2.0. These is no reason not to update them both.

[rmccue]

This will include WordPress/WordPress-Coding-Standards#1684 too.

[ntwb]

I've updated #151 and it now passes with the latest release of WPCS & VIPCS