PoC: compress files when adding them #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
force-pushed
the
bugfix/compress-files
branch
from
15cf5f4 to
ab9255c
Compare
Member
Author
|
@rsauvatinet I'll be closing this now as it doesn't seem to bring any perf. improvement (the opposite actually). Feel free to investigate on your own if you believe there is a condition under which the result might be different, as you can see the changes required to try that are minimal. Also note if you want to profile this, once you configured Blackfire you can do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to compress all the files as we add them instead of compressing all of them at the end.
Blackfire profile: link
profile 2: link
Closes #4