Skip to content

Review some parameters #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
theofidry merged 4 commits into from
Mar 5, 2018
Merged

Review some parameters #89

theofidry merged 4 commits into from
Mar 5, 2018

Conversation

@theofidry
Copy link
Member

@theofidry theofidry commented Mar 5, 2018

  • No longer accept a string value for the compactors setting
  • No longer accept a numerical value for the algorithm and compression settings
  • Allow null for the algorithm and compression settings
  • Rework the documentation for chmod, compactors, compression and algorithm

theofidry added 4 commits March 5, 2018 20:12
@theofidry
Do not allow strings for compactors
69c7475
@theofidry
Rework doc
228d3fb 
- Allow `null` for `algorithm` and `compression
- Drop support for numerical values for `algorithm` and `compression`
@theofidry
Fix tests
5ec1c74
@theofidry
fix
c9037bb
@theofidry theofidry merged commit d7ff0c0 into box-project:master Mar 5, 2018
@theofidry theofidry deleted the bugfix/compactors branch March 5, 2018 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@theofidry