Should we manage supporting deps? #218
Replies: 2 comments 1 reply
-
|
With which extensions are you facing this issue currently? |
Beta Was this translation helpful? Give feedback.
-
|
Pkl.pkl-vscode would be the main one as it requires external java to operate and the system wide version at least on mine wasn't high enough to run it. Sonarlint in my experience also occasionally has lsp bugs & crashes with a JVM that's too old. OXC is mainly so that the dev machines & ci linking use the same node version for oxfmt etc. Also we run pkl & oxfmt via HK for linting before commit which obv runs on cli, meaning if you don't have these settings, running the tool in cli in vscode uses a different node/java to what the extension doing the same lints does 😩 Not sure what others would prefer to be default in this situation, but I imagine it's reasonable to assume if you've added node, Java etc to your Mise developer tools that all your vscode plugins that have binaries installed via Mise would also use node/JVM deps from Mise as well? |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Many VScode extensions also depend on other tools along with their own binary, like Java or Node. If a user has installed these deps with mise, it often makes sense to use the same local version used by the project, otherwise globally resolved versions differ between developers potentially leading to hard to reproduce bugs in VSCode extensions. Personally, I have settings like:
{ "mise.customFolderExtensions": [ { "extensionId": "SonarSource.sonarlint-vscode", "toolSources": [ "java" ], "vscodeSetting": { "key": "sonarlint.ls.javaHome" }, "folderName": "java" } ], "mise.customBinaryExtensions": [ { "extensionId": "SonarSource.sonarlint-vscode", "toolSources": [ "node" ], "supportsShims": true, "supportsSymlinks": true, "vscodeSetting": { "key": "sonarlint.pathToNodeExecutable" }, "binName": "node" }, { "extensionId": "oxc.oxc-vscode", "toolSources": [ "node" ], "supportsShims": true, "supportsSymlinks": true, "vscodeSetting": { "key": "oxc.path.node" }, "binName": "node" }, { "extensionId": "Pkl.pkl-vscode", "toolSources": [ "java" ], "supportsShims": true, "supportsSymlinks": true, "vscodeSetting": { "key": "pkl.lsp.java.path" }, "binName": "java" } ] }Are these settings we should also be adding for supported plugins? I can't see how it would hurt as they will only enable if that mise tool is installed, and with global tool resolution enabled it'll use the global version anyway. Although maybe some users may be confused why one project's plugin might use Node from brew while another might use mise installed node, etc.
Thoughts?
Beta Was this translation helpful? Give feedback.
All reactions