Skip to content

refactor!: removed ionic-framework and integrated html5up as Vue components #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hwakabh merged 8 commits into from
Nov 28, 2024
Merged

refactor!: removed ionic-framework and integrated html5up as Vue components #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
15f8f0e
chore: updated deps for frontend.
hwakabh Nov 26, 2024
cfdc607
feat: implemented html5up to vue project (WIP)
hwakabh Nov 26, 2024
d187281
refactor: refactored App.vue.
hwakabh Nov 27, 2024
9335f95
feat: removed ionic-framework and integreated html5up to Vue.
hwakabh Nov 27, 2024
d0bb519
chore: removed image_url from payload.
hwakabh Nov 27, 2024
12dbd7d
chore: applied code-rabbit reviews.
hwakabh Nov 27, 2024
abb3112
ui: activated blog buttons.
hwakabh Nov 27, 2024
4d1502f
chore: applied reviews and enabled fullscreen in each page.
hwakabh Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions api-server/fixtures/payloads/works.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
{
"title": "Bennu Official Homepage",
"url": "https://bennu-official.page/home/",
"imageUrl": "",
"gitHubRepoUrl": "https://github.com/hwakabh/bennu-official",
"descriptions": "Official Homepage of Bennu",
"techStacks": [
Expand All @@ -17,7 +16,6 @@
{
"title": "random-travelers",
"url": "https://random-travelers.com",
"imageUrl": "",
"gitHubRepoUrl": "https://github.com/hwakabh/random-travelers",
"descriptions": "People who make thier decisions decided by Cloud Native",
"techStacks": [
Expand All @@ -29,7 +27,6 @@
{
"title": "6ow3idGirl",
"url": "https://6ow3idgirl.com",
"imageUrl": "",
"gitHubRepoUrl": "https://github.com/hwakabh/6ow3idGirl",
"descriptions": "Official Homepage of 6ow 3id girl",
"techStacks": [
Expand All @@ -39,7 +36,6 @@
{
"title": "waseda-mochida",
"url": "",
"imageUrl": "",
"gitHubRepoUrl": "https://github.com/hwakabh/waseda-mochida",
"descriptions": "Official Homepage of Waseda Mochida",
"techStacks": [
Expand All @@ -51,7 +47,6 @@
{
"title": "Luana Shanti",
"url": "https://luana-shanti.jp",
"imageUrl": "",
"gitHubRepoUrl": "",
"descriptions": "Luana Shanti Homepage hosted by WordPress",
"techStacks": [
Expand Down
13 changes: 7 additions & 6 deletions web-frontend/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<link rel="icon" href="/favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Hiroyuki Wakabayashi - hwakabh</title>
</head>
<head>
<title>hwakabh</title>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link rel="icon" href="/favicon.ico" />
</head>

<body>
<div id="app"></div>
<script type="module" src="/src/main.js"></script>
Expand Down
55 changes: 0 additions & 55 deletions web-frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions web-frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
"node": "20.9.0"
},
"dependencies": {
"@ionic/vue": "^8.4.0",
"@ionic/vue-router": "^8.4.0",
"axios": "^1.7.8",
"vue": "^3.5.13",
"vue-router": "^4.5.0",
Expand All @@ -28,7 +26,7 @@
"vitest": "^2.1.5"
},
"optionalDependencies": {
"@rollup/rollup-linux-x64-gnu": "4.27.4",
"@rollup/rollup-linux-arm64-gnu": "4.27.4"
"@rollup/rollup-linux-arm64-gnu": "4.27.4",
"@rollup/rollup-linux-x64-gnu": "4.27.4"
}
}
68 changes: 16 additions & 52 deletions web-frontend/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,64 +1,28 @@
<script setup>
// required for page scrolling
import { IonPage, IonContent } from '@ionic/vue';
import { IonCol, IonGrid, IonRow } from '@ionic/vue';
import SidebarContent from './components/SidebarContent.vue';
import FooterContent from './components/FooterContent.vue';
</script>

<template>
<ion-page>
<ion-content>

<header>
<ion-grid>
<ion-row>
<ion-col />
<ion-col size="8">
<div class="route-wrap">
<router-link to="/">Home</router-link>
|
<router-link to="/about">About me</router-link>
|
<router-link to="/cv">Resume</router-link>
|
<router-link to="/works">Side Gigs</router-link>
</div>
</ion-col>
<ion-col />
</ion-row>
</ion-grid>

</header>

<main>
<ion-grid>
<ion-row>
<ion-col />
<ion-col size="10">
<!-- <script src="assets/js/jquery.min.js"></script>
<script src="assets/js/jquery.scrollex.min.js"></script>
<script src="assets/js/jquery.scrolly.min.js"></script>
<script src="assets/js/browser.min.js"></script>
<script src="assets/js/breakpoints.min.js"></script>
<script src="assets/js/util.js"></script>
<script src="assets/js/main.js"></script> -->
Comment on lines +8 to +14
Copy link

@coderabbitai coderabbitai bot Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Remove commented script tags and properly integrate required scripts.

The commented script tags should either be removed or properly integrated:

  1. If these scripts are needed, move them to your Vue entry point (main.js) and import them properly
  2. If they're not needed, remove the commented code entirely
  3. If they're part of HTML5UP, consider using npm packages where available
-<!-- <script src="assets/js/jquery.min.js"></script>
-<script src="assets/js/jquery.scrollex.min.js"></script>
-<script src="assets/js/jquery.scrolly.min.js"></script>
-<script src="assets/js/browser.min.js"></script>
-<script src="assets/js/breakpoints.min.js"></script>
-<script src="assets/js/util.js"></script>
-<script src="assets/js/main.js"></script> -->


<router-view />
<SidebarContent />

</ion-col>
<ion-col />
</ion-row>
</ion-grid>
</main>
<div id="wrapper">
<router-view />
</div>

<footer>
<ion-grid>
<ion-row>
<ion-col />
<ion-col size="10">
<FooterContent />
</ion-col>
<ion-col />
</ion-row>
</ion-grid>
</footer>
<footer id="footer" class="wrapper style1-alt">
<FooterContent />
</footer>

</ion-content>
</ion-page>
</template>

<style scoped>
Expand Down
Loading
Loading