Skip to content

refactor: deprecated endpoint and UI contents #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hwakabh merged 6 commits into from
Dec 1, 2024
Merged

refactor: deprecated endpoint and UI contents #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5de10ee
refactor(api): removed /api/v1/cv/projects.
hwakabh Dec 1, 2024
364e55d
chore(fixture): updated descriptions.
hwakabh Dec 1, 2024
67a83e4
feat(ui): enabled to loop techStacks elements in /works.
hwakabh Dec 1, 2024
e8ad255
chore(ui): updated works links and techStacks.
hwakabh Dec 1, 2024
47fd3a1
Merge branch 'main' into refactor/437/remove_endpoints
hwakabh Dec 1, 2024
5316121
chore(schema): updated for deprecation.
hwakabh Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api-server/fixtures/payloads/publications.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"list": [
{
title: 'VMware Explore 2022',
descriptions: 'Presentation of step-by-step automations of Kubernetes Operations',
descriptions: 'Presentation of step-by-step CI/CD pipeline design for Kubernetes Operations',
date: '2022/11/16',
filename: '20221116_VMware-Explore-2022-Japan_MA22278.pdf',
},
Expand Down
15 changes: 9 additions & 6 deletions api-server/fixtures/payloads/works.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
{
"title": "Bennu Official Homepage",
"url": "https://bennu-official.page/home/",
"gitHubRepoUrl": "https://github.com/hwakabh/bennu-official",
"gitHubRepoUrl": "https://github.com/hwakabh/bennu-official.page",
Copy link

@coderabbitai coderabbitai bot Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Repository URLs need attention - some are not accessible as specified

The verification revealed inconsistencies in the repository URLs:

  • hwakabh/bennu-official.page exists and is accessible
  • hwakabh/6ow3idGirl.com exists but with different casing (6ow3idgirl.com)
  • hwakabh/waseda-mochida.com exists but without the .com extension (waseda-mochida)

Please update the repository URLs in the following files to match their actual GitHub URLs:

  • api-server/fixtures/payloads/works.json5 (lines 30, 40)
🔗 Analysis chain

Verify repository URL accessibility.

The GitHub repository URLs have been updated with domain extensions. Let's verify these repositories exist and are accessible.

Also applies to: 30-30, 40-40

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify GitHub repositories exist and are accessible

# Check repository existence using GitHub API
for repo in "hwakabh/bennu-official.page" "hwakabh/6ow3idGirl.com" "hwakabh/waseda-mochida.com"; do
  echo "Checking $repo..."
  gh api "repos/$repo" --jq '.html_url'
done

Length of output: 847

"descriptions": "Official Homepage of Bennu",
"techStacks": [
"Python",
"Django",
"Kubernetes", "Google Kubernetes Engine",
"Cloud Native Builpacks", "Google Cloud Buildpacks",
"Kubernetes (Google Kubernetes Engine)",
"Cloud Native Builpacks (Google Cloud Buildpacks)",
],
},
{
Expand All @@ -27,21 +27,23 @@
{
"title": "6ow3idGirl",
"url": "https://6ow3idgirl.com",
"gitHubRepoUrl": "https://github.com/hwakabh/6ow3idGirl",
"gitHubRepoUrl": "https://github.com/hwakabh/6ow3idGirl.com",
"descriptions": "Official Homepage of 6ow 3id girl",
"techStacks": [
"Express",
"Next.js"
]
},
{
"title": "waseda-mochida",
"url": "",
"gitHubRepoUrl": "https://github.com/hwakabh/waseda-mochida",
"gitHubRepoUrl": "https://github.com/hwakabh/waseda-mochida.com",
"descriptions": "Official Homepage of Waseda Mochida",
"techStacks": [
"Python",
"Flask",
"LINE Pay"
"LINE Pay API",
"Heroku"
]
},
{
Expand All @@ -51,6 +53,7 @@
"descriptions": "Luana Shanti Homepage hosted by WordPress",
"techStacks": [
"WordPress",
"CSS"
]
},
]
Expand Down
19 changes: 0 additions & 19 deletions api-server/routes/cv.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,25 +55,6 @@ router.get('/educations', function(req, res, next) {
});
});

router.get('/projects', async (req, res, next) => {
// #swagger.tags = ['CV']
// #swagger.summary = 'returns list of projects with static contents'
// #swagger.description = '/api/v1/cv/projects'
const projects = await axios.get(url)
.then(response => {
return response.data.projects
})
.catch(error => {
console.log(error);
})

res.header('Content-Type', 'application/json; charset=utf-8');
res.json({
"path": req.originalUrl,
"content": projects
});
});

router.get('/publications', function(req, res, next) {
// #swagger.tags = ['CV']
// #swagger.summary = 'returns list of publications with static contents'
Expand Down
14 changes: 0 additions & 14 deletions schemas/swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,20 +146,6 @@
}
}
},
"/api/v1/cv/projects": {
"get": {
"tags": [
"CV"
],
"summary": "returns list of projects with static contents",
"description": "/api/v1/cv/projects",
"responses": {
"200": {
"description": "OK"
}
}
}
},
"/api/v1/cv/publications": {
"get": {
"tags": [
Expand Down
5 changes: 5 additions & 0 deletions web-frontend/src/pages/Works.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ onMounted(() => {
<strong><a :href="w.url" target="_blank"> {{ w.title }} </a></strong>
<br>
{{ w.descriptions }}
<br>
<span v-for="(t, idx) in w.techStacks" :key="idx">
{{ t }}
<span v-if="idx+1 != w.techStacks.length"> / </span>
</span>
</li>
</ul>

Expand Down