Skip to content

feat: frontend enhancement #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hwakabh merged 3 commits into from
Apr 3, 2025
Merged

feat: frontend enhancement #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6440d2
chore: moved license texts into footer.
hwakabh Apr 3, 2025
b97e98e
chore: updated href for blogs.
hwakabh Apr 3, 2025
5239303
test: updated expected values.
hwakabh Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions web-frontend/src/components/FooterContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ const props = defineProps({});
<template>
<div class="inner">
<ul class="menu">
<li>&copy; Untitled. All rights reserved.</li>
<li>Design: <a href="http://html5up.net">HTML5 UP</a> | Revised: <a href="https://github.com/hwakabh">hwakabh</a></li>
<li>&copy; hwakabh. All rights reserved.</li>
<li>Design: <a href="http://html5up.net">HTML5 UP</a></li>
<li>Revised: <a href="https://github.com/hwakabh">hwakabh</a></li>
<li>released for free under the <a href="http://html5up.net/license">Creative Commons</a></li>
</ul>
</div>
</template>
Expand Down
4 changes: 3 additions & 1 deletion web-frontend/src/pages/About.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,9 @@ axios.get('/api/v1/cv/publications')
<br>
<div>
<ul class="actions">
<li><router-link to="/help" class="button primary">Blog</router-link></li>
<div class="button primary"><a href="https://hwakabh.tumblr.com" target="_blank" rel="noopener noreferrer">Blog</a></div>
<!-- TODO: implement http-clients to tumbler via backend API -->
<!-- <li><router-link to="/help" class="button primary">Blog</router-link></li> -->
Comment on lines +89 to +91
Copy link

@coderabbitai coderabbitai bot Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

HTML structure needs improvement for semantic correctness

The current implementation has two issues:

  1. Using a <div> directly inside a <ul> is not semantically correct HTML. List items should always be wrapped in <li> tags.
  2. The "button primary" class is now on the div instead of directly on the interactive element.
-  <div class="button primary"><a href="https://hwakabh.tumblr.com" target="_blank" rel="noopener noreferrer">Blog</a></div>
-  <!-- TODO: implement http-clients to tumbler via backend API -->
-  <!-- <li><router-link to="/help" class="button primary">Blog</router-link></li> -->
+  <li><a href="https://hwakabh.tumblr.com" target="_blank" rel="noopener noreferrer" class="button primary">Blog</a></li>
+  <!-- TODO: implement http-clients to tumbler via backend API -->
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<div class="button primary"><a href="https://hwakabh.tumblr.com" target="_blank" rel="noopener noreferrer">Blog</a></div>
<!-- TODO: implement http-clients to tumbler via backend API -->
<!-- <li><router-link to="/help" class="button primary">Blog</router-link></li> -->
<li><a href="https://hwakabh.tumblr.com" target="_blank" rel="noopener noreferrer" class="button primary">Blog</a></li>
<!-- TODO: implement http-clients to tumbler via backend API -->

</ul>
</div>
</div>
Expand Down
47 changes: 24 additions & 23 deletions web-frontend/src/pages/Home.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,46 +1,47 @@
<script setup>
import { ref } from 'vue'
import VueWriter from 'vue-writer'

// import { ref } from 'vue'
// import VueWriter from 'vue-writer'
import SocialLink from '../components/SocialLink.vue'

const words = ref([
"Welcome!",
"ようこそ！",
"欢迎！",
"환영합니다！",
"Bienvenue!",
"Benvenuto!",
"Willkommen!",
"¡Bienvenido!",
"Bem-vindo!",
"Ласкаво просимо!",
"ยินดีต้อนรับ!",
"Nau mai!",
"ברוכים הבאים!",
])
// const words = ref([
// "Welcome!",
// "ようこそ！",
// "欢迎！",
// "환영합니다！",
// "Bienvenue!",
// "Benvenuto!",
// "Willkommen!",
// "¡Bienvenido!",
// "Bem-vindo!",
// "Ласкаво просимо!",
// "ยินดีต้อนรับ!",
// "Nau mai!",
// "ברוכים הבאים!",
// ])
</script>

<template>

<VueWriter
<!-- <VueWriter
class="top-message"
:array="words"
:delay="1000"
:type-speed="80"
:erase-speed="80"
>
</VueWriter>
</VueWriter> -->

<section id="intro" class="wrapper style1 fullscreen fade-up">
<div class="inner">
<h1 class="top-message">Hi, there!</h1>
<p>Just another fine responsive site template designed by <a href="http://html5up.net">HTML5 UP</a><br />
and released for free under the <a href="http://html5up.net/license">Creative Commons</a>.</p>
<p>
Whether it is good or bad with your decisions, the results can be known only afterwards, <br />
the sky is the limit for your creativities !
</p>
<SocialLink />
<br>
<ul class="actions">
<li><router-link to="/about" class="button scrolly">Learn more</router-link></li>
<li><router-link to="/about" class="button scrolly">About me</router-link></li>
</ul>
</div>
</section>
Expand Down
2 changes: 1 addition & 1 deletion web-frontend/tests/FooterContent.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ describe("component: FooterComponent.vue", () => {
expect("FooterContent").toBe(FooterContent.__name)
})
test("Component can accept value as props and render as HTML", async () => {
const expected = "© Untitled. All rights reserved.Design: HTML5 UP";
const expected = "© hwakabh. All rights reserved.Design: HTML5 UPRevised: hwakabhreleased for free under the Creative Commons";
const wrapper = shallowMount(FooterContent)
// // if compoenents has props
// const wrapper = shallowMount(FooterContent, { props: {
Expand Down
Loading