fix(listDocs,destroyStore): use trampoline in lieu of recursion to prevent callstack overflow #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30
This PR removes the recursion that was being used to power things like
listDocsand deleting all keys ondestroyStoreand replaces it with atrampoline. This will allow those calls to succeed, for larger datasets, that would otherwise fail due to deep recursion.This PR also exposes
hashSlotwhich enables backwards compatibility with version2of the adapter, which does not use hash slots when creating keys. WithhashSlotdisabled, multi-key operations that can span multiple hashSlots will instead be performed individually to preventCROSSSLOTerrors like seen in #16 . Additional unit tests are implemented to ensure bothhashSlotandno hashSlotworks.