Skip to content

Conversation

@SimonBlanke
Copy link
Collaborator

@SimonBlanke SimonBlanke commented Jun 9, 2025

This PR adds all optimization algorithms from GFO in the new hyperactive v5 API, to the opt module.

@SimonBlanke SimonBlanke added the enhancement New feature or request label Jun 9, 2025
@SimonBlanke SimonBlanke self-assigned this Jun 9, 2025
@SimonBlanke SimonBlanke requested a review from fkiraly June 9, 2025 09:31
@fkiraly
Copy link
Collaborator

fkiraly commented Jun 10, 2025

so, going back to the hyperactive.opt.gfo folder structure? Fine with me

@SimonBlanke
Copy link
Collaborator Author

so, going back to the hyperactive.opt.gfo folder structure?

This is an "intermediate" commit for testing stuff out and to see it in practice. The fact, that we provide the opt. algos on the "opt"-directory level (in the init-file of the opt-directory) changes the situation a bit:
https://github.com/SimonBlanke/Hyperactive/pull/121/files#diff-20f5f20be4fd0ec4ef23abe4e98a58ce61db42894ea1b94499d66e9687f3c6bf

Because now it is less about the user-experience (since all opt. algos can be imported from the same path anyway) and more about how the code should be structured in the backend.

@SimonBlanke SimonBlanke changed the title Add mission optimization algorithms from GFO Add optimization algorithms from GFO Jun 10, 2025
@fkiraly
Copy link
Collaborator

fkiraly commented Jun 10, 2025

ok, fine with me either way!
(let's just ensure it stays consistent)

@fkiraly
Copy link
Collaborator

fkiraly commented Jun 21, 2025

Hope it is fine to directly commit to this branch - please revert if not and let me know.

  • I have moved the default handling from the top level base class to _BaseGFOadapter - we only know the defaults are correct for gfo instances.
  • I also added a to_dict_np method that handles the numpy coercion of the search dict for now.

Please let me know of any feedback.

@fkiraly
Copy link
Collaborator

fkiraly commented Jun 21, 2025

Looks like this fixed it. There are 8 left which look deeper, i.e., in gfo.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be happy with this - no failures.

  • I have reported the potential bug with replacement=False in here: #135
  • I have opened an issue to discuss handling of categoricals: #136

@fkiraly
Copy link
Collaborator

fkiraly commented Jun 22, 2025

(change made by me are from pair programming remotely)

@SimonBlanke SimonBlanke marked this pull request as ready for review June 23, 2025 15:38
@SimonBlanke SimonBlanke merged commit 8a2a5ae into master Jun 23, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants