-
Notifications
You must be signed in to change notification settings - Fork 65
[ENH] parallelization backends for grid and random search #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, I noticed test times are going up substantially, and one job timed out 30min.
We should find out what is causing that. It does not seem to be the case in #150.
The only differences between these two branches are some examples. I suspect, that the CI tests from a different branch were running while this one started tests. This does not mean, that we shouldn't make the test pipeline faster. But this does mean, that this PR should not tackle this issue. |
fkiraly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it´s coming from ray - should we skip those tests for now?
Yes, let's skip it for now. Could you open an issue on how to test ray without blowing up our test pipeline, so that we remember this? |
From Original PR #150:
This PR introduces parallelization backends for GridSearch and RandomSearch.
Both estimators now allow to specify backend and backend_params in the constructor, which allows selection of a parallelization backend and configuration parameters for it - the default being "None", i.e., plain loop.
This uses the parallel utilities also used in sktime and skpro, with a mid-term plan to move these to scikit-base.