Skip to content

Conversation

@MikeShi42
Copy link
Contributor

image

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2025

🦋 Changeset detected

Latest commit: 461f0bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Nov 12, 2025 1:20am

@claude
Copy link

claude bot commented Nov 12, 2025

PR Review

  • ⚠️ Redundant optional chaining in DBSearchPage.tsx:185Number.parseInt(numRows) already handles null/undefined; remove ?. after (returns NaN for invalid input, causing 'NaN' to display)
  • ⚠️ Missing null check after parseInt → Check if result is NaN: const parsed = Number.parseInt(numRows); return isNaN(parsed) ? '' : \Scanned Rows: ${parsed.toLocaleString()}``

Otherwise looks good - formatting numbers for readability is a nice UX improvement!

@MikeShi42 MikeShi42 merged commit 64b5673 into main Nov 12, 2025
11 checks passed
@github-actions
Copy link
Contributor

E2E Test Results

All tests passed • 40 passed • 3 skipped • 302s

Status Count
✅ Passed 40
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

View full report →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants