-
Notifications
You must be signed in to change notification settings - Fork 328
remove react select #1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove react select #1367
Conversation
🦋 Changeset detectedLatest commit: 3e83926 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review✅ Overall: Good cleanup, but one critical type issue Critical Issues
Positive Changes
Notes
|
E2E Test Results✅ All tests passed • 39 passed • 3 skipped • 394s
|
elizabetdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested in Google Chrome.
I also have the same test failing on a different branch.
pulpdrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two minor nits
|
@brandon-pereira I merged the very big PR that removes bootstrap, and it was causing a conflict here. So I fixed it and merged main: ef1ed44. |
|
@elizabetdev @pulpdrew pushed some improvements, removed DBSelect and just called the Mantine Select.. also improved the flakey test so it should be better now :) |
pulpdrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the test fix!
Removes react-select dependency and replaces with Mantine select.
Most of the uses of this component weren't actually in use, so this ended up being pretty easy.
As suggested by @elizabetdev as part of the mantine / bootstrap cleanup