Skip to content

fix: Prevent incorrect dashboard side panel close #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2025
Merged

fix: Prevent incorrect dashboard side panel close #1372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d96e62
fix: Prevent incorrect dashboard side panel close
pulpdrew Nov 17, 2025
4acf4ba
Merge branch 'main' into drew/remove-click-outside
kodiakhq[bot] Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ninety-baboons-shop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hyperdx/app": patch
---

fix: Prevent incorrect dashboard side panel close
13 changes: 1 addition & 12 deletions packages/app/src/components/DBRowSidePanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { useHotkeys } from 'react-hotkeys-hook';
import { TSource } from '@hyperdx/common-utils/dist/types';
import { ChartConfigWithDateRange } from '@hyperdx/common-utils/dist/types';
import { Box, Drawer, Flex, Stack } from '@mantine/core';
import { useClickOutside } from '@mantine/hooks';

import DBRowSidePanelHeader, {
BreadcrumbNavigationCallback,
Expand Down Expand Up @@ -527,12 +526,6 @@ export default function DBRowSidePanelErrorBoundary({

useHotkeys(['esc'], _onClose, { enabled: subDrawerOpen === false });

const drawerRef = useClickOutside(() => {
if (!subDrawerOpen && !isChildModalOpen && rowId != null) {
_onClose();
}
}, ['mouseup', 'touchend']);

return (
<Drawer
opened={rowId != null}
Expand All @@ -554,11 +547,7 @@ export default function DBRowSidePanelErrorBoundary({
zIndex={drawerZIndex}
>
<ZIndexContext.Provider value={drawerZIndex}>
<div
className={styles.panel}
ref={drawerRef}
data-testid="row-side-panel"
>
<div className={styles.panel} data-testid="row-side-panel">
<Box className={styles.panelDragBar} onMouseDown={startResize} />
<ErrorBoundary
fallbackRender={error => (
Expand Down
Loading