This repository was archived by the owner on Feb 8, 2021. It is now read-only.
Vsock kernel support #194
Closed
Vsock kernel support #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devimc
reviewed
Sep 30, 2016
src/init.c
Outdated
| #else | ||
| ctl_serial = "sh.hyper.channel.0"; | ||
| tty_serial = "sh.hyper.channel.1"; | ||
| if (hyper_cmd("/sbin/modprobe vmw_vsock_virtio_transport") < 0) { |
Contributor
There was a problem hiding this comment.
nice patch, could you please remove /sbin ?
related with #191
Member
Author
There was a problem hiding this comment.
sure, I'll drop it. Thanks for pointing it out.
bergwolf
force-pushed
the
vsock
branch
2 times, most recently
from
aff23bf to
16258c0
Compare
gao-feng
reviewed
Nov 2, 2016
src/init.c
Outdated
|
|
||
| static int hyper_vsock_msg_accept(struct hyper_event *he, int efd) | ||
| { | ||
| return hyper_vsock_accept(he, efd, &ctl.chan, &hyper_vsock_ttyfd_ops); |
Member
Author
|
iperf (patched with vsock support, see https://github.com/bergwolf/iperf/tree/vsock) tests with vsock connection. vsock bandwidth is about 3x of IPv4. Both were tested in the same container (64MB with single core). vsock result: IPv4 iperf results: |
listen control channel on port 2718, and message channel on 2719. Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Set up control channel and message channel if unset yet. Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
To have larger buffer size and also handle HUP events so that it is possible to reconnect to hyperstart. Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
So that we know when runv closes a connection. Signed-off-by: Peng Tao <bergwolf@gmail.com>
1. when read returns 0, it means remotes has closed socket, for normal TCP connections. 2. when read returns -ENOTCONN for vsock, it means remote has closed the socket. We should be able to just handle case 1) if we patch vsock kernel implementation to match normal TCP connection behavior. Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
|
retest this please |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.