This repository was archived by the owner on Feb 8, 2021. It is now read-only.
fix memory leak in parse.c #239
Merged
+43
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laijs
reviewed
Dec 16, 2016
src/parse.c
Outdated
| strlen(s) == (size_t)(t->end - t->start)); | ||
| } | ||
|
|
||
| void hyper_print_unknown_section(char *json, jsmntok_t *t) |
Contributor
There was a problem hiding this comment.
how about use the name unknown key or unknown field?
laijs
reviewed
Dec 16, 2016
| dprintf(stdout, "in maps incorrect %s\n", | ||
| json_token_str(json, &toks[i])); | ||
| hyper_print_unknown_section(json, &toks[i]); | ||
| return -1; |
Contributor
There was a problem hiding this comment.
actually, the best way to handle unknown keys is ignoring them.
let runv handle the api compatibility.
it will make the api-updating easier.
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
ignore is good, but should we print out the debug message? If yes, this pr is still needed
Signed-off-by: Gao feng <omarapazanadi@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gao feng omarapazanadi@gmail.com