Skip to content
This repository was archived by the owner on Feb 8, 2021. It is now read-only.

Conversation

@dvoytik
Copy link
Contributor

@dvoytik dvoytik commented Mar 22, 2017

Which can be used to exclude kernel modules from rootfs in
the image building phase.

Signed-off-by: Dmitry Voytik dmitry.voytik@huawei.com

@Jimmy-Xu
Copy link

Can one of the admins verify this patch?

@gnawux
Copy link
Member

gnawux commented Mar 22, 2017

I think it's would be better to support specifying the customized kernel path in the configure command line, such as

.```
./configure --with-custom_kernel=/path/to/the/kernel

@dvoytik
Copy link
Contributor Author

dvoytik commented Mar 22, 2017

@gnawux I agree, that way would be more generic and cover other problems. But also it would need to overhaul the whole build/make-initrd.sh at least. Unfortunately I don't have time to do this and test other case like virtualbox, aarch64, etc.
Actually personally I'd abandon totally the image build part and rely completely on https://buildroot.org/. With buildroot you would need only to put hyperstart binary in specific location, other stuff (like iptables, kernel modules, etc.) is covered by buildroot. Also it would simplify cross-building for other architectures.

@gao-feng
Copy link
Contributor

Looks weird having --with-custom_kernel without --with-custom_modules, actually we need --with-custom_modules more IMO.

@dvoytik
Copy link
Contributor Author

dvoytik commented Mar 22, 2017

@gao-feng Okay, I can rename it to --with-custom_modules. Let me update the pull request. How do your prefer - a squash or additional commit on top of this?

@dvoytik
Copy link
Contributor Author

dvoytik commented Mar 22, 2017

@gao-feng I am a bit confused. Do you want me to keep the logic of the patch? In my patch I just want to be able to exclude provided by hyperstart kernel modules (we don't use them in our project). If yes then maybe it make sense to rename the option to "--without-kmodules" and by default it is turned off (i.e. resulting to inclusion of the provided kernel modules, so no breaking of previous build functionality)?

@gao-feng
Copy link
Contributor

@dvoytik ok, let's simplify the logic, --without-kmodules looks good to me

Which can be used to exclude kernel modules from rootfs in the image
building phase. Otherwise by default included kernel modules are copied
to the resulting rootfs image.

Signed-off-by: Dmitry Voytik <dmitry.voytik@huawei.com>
@gao-feng
Copy link
Contributor

LGTM

@gao-feng gao-feng merged commit 41262e6 into hyperhq:master Mar 24, 2017
@laijs laijs changed the title build: add --with-custom_kernel configure flag build: add --without-kmodules configure flag Mar 26, 2017
@Jimmy-Xu
Copy link

Can one of the admins verify this patch?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants