This repository was archived by the owner on Feb 8, 2021. It is now read-only.
share /dev/shm for all the containers in the pod #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix hyperhq#323 All containers in the pod share the same ipc namespace. However, posix ipc primitives are shm_open() family whose behaviors implemented in glibc are to create&share the shm objects within /dev/shm (or scans /proceed/mounts for any tmpfs if /dev/shm is not tmpfs). So we have to create the only one tmpfs mount and share it to all the containers. Signed-off-by: Lai Jiangshan <jiangshanlai@gmail.com>
gnawux
reviewed
Aug 30, 2017
| */ | ||
| static int hyper_setup_shm(struct hyper_pod *pod) | ||
| { | ||
| if (hyper_mkdir("/tmp/hyper/shm", 0755) < 0) { |
Member
There was a problem hiding this comment.
Is it good to be placed in /tmp? how about /var/lib or somewhere like?
Contributor
Author
There was a problem hiding this comment.
in hyperstart, all pod/containers related things are created on /tmp/hyper
Member
|
lgtm! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #323
All containers in the pod share the same ipc namespace. However,
posix ipc primitives are shm_open() family whose behaviors
implemented in glibc are to create&share the shm objects within
/dev/shm (or scans /proceed/mounts for any tmpfs if /dev/shm
is not tmpfs).
So we have to create the only one tmpfs mount and share it
to all the containers.
Signed-off-by: Lai Jiangshan jiangshanlai@gmail.com