Skip to content
This repository was archived by the owner on Feb 8, 2021. It is now read-only.

Conversation

@YaoZengzeng
Copy link
Contributor

just a simple wrapper of runv kill container-id KILL

Signed-off-by: Yao Zengzeng yaozengzeng@zju.edu.cn

…r-id KILL

Signed-off-by: Yao Zengzeng <yaozengzeng@zju.edu.cn>
@Crazykev
Copy link
Contributor

Will it fail if exec runv delete after runv kill ?

@YaoZengzeng
Copy link
Contributor Author

@Crazykev In fact, we can't distinguish a container being killed before and a container that never exist.
(1)、Now runv is stateless actually, the container is running or none.After kill, it just exited.
(2)、There in no api of deleting in containerd.So we can just do like this to work around.
Any good suggestions?

@Crazykev
Copy link
Contributor

AFAK, for a long term, we need to follow opencontainers/runtime-spec#513 when it land. And in runv, maybe it's more easy to figure out what is the proper way to define delete after we seprerate create and start.
And if this is only a workaround for ocid integration for now, that we need a delete. At least we need to gurantee delete after kill will not fail, that is why I would ask that.

@gao-feng
Copy link
Contributor

deleting container is needed, please consider to implement it in containerd.

@laijs laijs closed this May 17, 2017
@laijs laijs reopened this May 17, 2017
@laijs
Copy link
Contributor

laijs commented Aug 3, 2017

@YaoZengzeng @Crazykev runv cli is being improved continuously and had just been refactored at #537 .

Moreover, runv delete was also implemented in #537. Feel free to test it and give any possible feedback.

Thank you for your contribution.

@laijs laijs closed this Aug 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants