This repository was archived by the owner on Feb 8, 2021. It is now read-only.
use APIVersion to wait for vm starting #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
it is better to remove the waitStarted argument from GetVm(). the call sites who use waitStarted=true could use hyperstart API instead. (example: call the vm.GetHyperstartAPIVersion() instead). and some call sites who use waitStarted=true should be converted to who uses waitStarted=false. alternative: call hyperstart API instead of WaitRespond in GetVm(). what do you think ? |
Contributor
Author
|
Will update this |
Change Launch function of vm as private function Signed-off-by: Gao feng <omarapazanadi@gmail.com>
Contributor
Author
|
@laijs updated |
laijs
changed the title
Contributor
|
LGTM |
jimoosciuc
pushed a commit
to jimoosciuc/runv
that referenced
this pull request
May 26, 2020
use APIVersion to wait for vm starting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Launch function of vm as private function
Signed-off-by: Gao feng omarapazanadi@gmail.com