This repository was archived by the owner on Feb 8, 2021. It is now read-only.
remove global SIGCHILD handler to avoid conflicts #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Executing Qemu via cmd.Run() installs it's own SIG handler to wait until Qemu has become a daemon. Under certain conditions the global SIGCHILD handler in containerd.go catches the SIGCHILD from the qemu process and the process is gone. Later on in /usr/local/go/src/os/wait_waitid.go the syscall SYS_WAITID triggerd by cmd.Run() also starts waiting for the process to become waitable but panics with 'waitid: no child processes'. This patch removes the global SIGCHILD handler. Signed-off-by: Peter Morjan <peter.morjan@de.ibm.com>
jimoosciuc
pushed a commit
to jimoosciuc/runv
that referenced
this pull request
May 26, 2020
remove global SIGCHILD handler to avoid conflicts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executing Qemu via cmd.Run() installs it's own SIG handler
to wait until Qemu has become a daemon.
Under certain conditions the global SIGCHILD handler in containerd.go
catches the SIGCHILD from the qemu process and the process is gone.
Later on in /usr/local/go/src/os/wait_waitid.go
the syscall SYS_WAITID triggerd by cmd.Run() also starts waiting for the
process to become waitable but panics with 'waitid: no child processes'.
This patch removes the global SIGCHILD handler.
Signed-off-by: Peter Morjan peter.morjan@de.ibm.com