This repository was archived by the owner on Feb 8, 2021. It is now read-only.
Show commit and version numbers #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Oh no, libvirt-dev doesn't have static library, so revert to dynamicallly built binary |
WeiZhang555
force-pushed
the
add-commit-to-version
branch
3 times, most recently
from
08b4d85 to
0111778
Compare
gao-feng
reviewed
May 17, 2017
Makefile.am
Outdated
| endif | ||
|
|
||
| COMMIT=`git describe --dirty --always --tags 2> /dev/null || true` | ||
| VERSION=`cat ./VERSION` |
Contributor
Author
There was a problem hiding this comment.
Yes, I added a "VERSION" file in this commit.
Contributor
There was a problem hiding this comment.
@WeiZhang555 I guess you don't need VERSION file, var VERSION already exists,
https://github.com/hyperhq/runv/blob/master/configure.ac#L5
https://github.com/hyperhq/runv/blob/master/configure.ac#L108
WeiZhang555
force-pushed
the
add-commit-to-version
branch
from
0111778 to
c8c1b83
Compare
Print git commit hash id when run `runv -v`, this will be helpful for debug. Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
WeiZhang555
force-pushed
the
add-commit-to-version
branch
from
c8c1b83 to
8627454
Compare
Contributor
Author
|
@gao-feng You're right, update now. |
Contributor
|
LGTM, thanks! |
jimoosciuc
pushed a commit
to jimoosciuc/runv
that referenced
this pull request
May 26, 2020
Show commit and version numbers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print git commit hash id when run
runv -v, this will be helpful fordebug.
Signed-off-by: Zhang Wei zhangwei555@huawei.com
Examples:
Means version: 0.7.0, latest tag is v0.7.0, we are 145 commits forward from that tag, current git commit is 23cbab6,
dirtymeans we have uncommited changes in repo when building the binary.