Track container status, and add delete command to OCI interface #526
Conversation
Track the OCI container states: - creating - created - running - stopped Signed-off-by: Antonios Motakis <antonios.motakis@huawei.com>
|
Currently looking into the failing tests. |
The list and state commands of the runv OCI interface always return "running" as the status of the container. Return the right status of each container via the containerd API. Signed-off-by: Antonios Motakis <antonios.motakis@huawei.com>
Currently runv automatically destroys any container that finish executing. The OCI spec defines that the container shall enter a stopped status instead; an explicit delete command is defined for cleaning up any container resources. Don't delete the container automatically on exit, and add an explicit delete command to the OCI interface of runv. To get around the limited containerd interface of runv, use a special status for containers that are about to be deleted. Signed-off-by: Antonios Motakis <antonios.motakis@huawei.com>
|
ping @laijs Can you take a look at this? ( @tvelocity is our guy from Europe 😄 ) |
|
@tvelocity we merged #537 , which aimed to improve the compatibility with the latest containerd and changed the cli much. Could you help check/update this PR? Thank you very much. |
|
@tvelocity runv cli is being improved continuously and had just been refactored at #537 . It seams that the changes in this pr is outdated. Moreover, However, Thank you for your contribution. |
4 participants
This PR implements the delete command as defined by the OCI spec.
To properly separate the container stopped state, from a deleted (non existent state) we add the necessary container states to runv.