1:1 1.8 melee PvP

[andrewgazelka]

Let's make sure melee combat is as 1:1 with 1.8 PvP as possible.

• Combat system immunity timeframe issues:
  • Current timeframe feels incorrect
  • Suggestion: Could be around 20 (units/frames?)
• Knockback mechanics:
  • Feels partially correct but has issues
  • Major problem: Allows infinite air combos on players
• Sprinting-related knockback:
  • Knockback calculation doesn't account for sprinting state
  • Issue with sprinting metadata:
    • "IS_SPRINTING" exists in component system
    • Not being tracked/stored properly in metadata
    • Unclear if this is a bug or implementation error

Would you like me to help investigate any of these specific issues? I can assist with reviewing or modifying the combat system code to address these concerns.

[linear]

HYP-64 1:1 1.8 PvP

[andrewgazelka]

@addbounty $50

[addbounty]

Bounty Added: $50 🎉

You've successfully added a bounty of $50 to this issue. The total bounty is now $50.

1. Tracking the Bounty: The bounty is now tied to this issue. Contributors can submit PRs to claim it by resolving the issue.
2. Decay Reminder: The bounty value decreases by 3% per day if not claimed.
3. Completion and Payout:
   • Once a PR is merged, the bounty system will start a 14-day acceptance window.
4. Acceptance/Challenge:
   • The issue author can accept or contest the payout during the window.
   • No response? Auto-acceptance after 14 days.

Happy bounty hunting! 🚀

[andrewgazelka]

The bounty amount will be distributed among contributors in proportion to the number of PRs they submit that contribute to fixing this issue, provided these PRs address work initiated after the issue was created and the bounty was announced. Let me know if we should consider alternative metrics.

[Tebarem]

BTW we fixed the metadata stuff in physics branch

[andrewgazelka]

BTW we fixed the metadata stuff in physics branch

what was the issue?

[Tebarem]

for some reason in hyperion/src/simulation/metadata/mod.rs
in fn component_and_prev<T>(world: &World) -> fn(&mut EntityView<'_>)
it was

observer!(world, flecs::OnSet, &T, [filter] &mut MetadataChanges,).each(|(value, changes)| {
        changes.encode(*value);
});

let register = |view: &mut EntityView<'_>| {
        view.set(T::default());
};

to

world
        .system_named::<(
            &mut (Prev, T),       //            (0)
            &mut T,               //                  (1)
            &mut MetadataChanges, //     (2)
        )>(system_name)
        .multi_threaded()
        .kind::<flecs::pipeline::OnStore>()
        .run(move |mut table| {
            while table.next() {
                unsafe {
                    let mut prev = table.field_unchecked::<T>(0);
                    let prev = prev.get_mut(..).unwrap();

                    let current = table.field_unchecked::<T>(1);
                    let current = current.get(..).unwrap();

                    let mut metadata_changes = table.field_unchecked::<MetadataChanges>(2);
                    let metadata_changes = metadata_changes.get_mut(..).unwrap();

                    // todo(perf): big optimization treating as raw bytes and SIMD
                    // or code that can easily be compiled to SIMD
                    // also can do copy_from_slice in one pass but want SIMD-optimized
                    // first
                    // todo(learn): reborrowing in-depth
                    for (idx, (prev, current)) in itertools::zip_eq(&mut *prev, current).enumerate()
                    {
                        if prev != current {
                            let metadata_changes = metadata_changes.get_unchecked_mut(idx);
                            metadata_changes.encode(*current);
                        }
                    }

                    prev.copy_from_slice(current);
                }
            }
        });

    let register = |view: &mut EntityView<'_>| {
        view.set_pair::<Prev, _>(T::default()).set(T::default());
    };

and Kump went back to the commit where it this broke it and we just set it back to what it used to be before it broke it. this also broke /spawn command but removing the prev and current check fixed it but broke bows

[Kumpelinus]

After #696 is merged, it feels like 1.8 PvP. Probably there are some more changes still left todo, but still good job so far everyone :)

[andrewgazelka]

After #696 is merged, it feels like 1.8 PvP. Probably there are some more changes still left todo, but still good job so far everyone :)

yea before closing this probably want to get someone on who is big into PvP and test it with them. I know one such person.

• continuous deploy server so anyone can join #707 going to integrate this and then should be easier for people to join and test