Skip to content

Conversation

@TestingPlant
Copy link
Collaborator

This fixes a panic that would've occured from fastrand due to having an empty range due to there being no teammates.

This fixes a panic that would've occured from fastrand due to having an
empty range due to there being no teammates.
@github-actions github-actions bot added the fix label Jan 21, 2025
@github-actions
Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  24.1 ns ...  24.1 ns ]      -0.13%
ray_intersection/aabb_size_1                       [  24.1 ns ...  24.1 ns ]      -0.00%
ray_intersection/aabb_size_10                      [  27.4 ns ...  27.3 ns ]      -0.19%
ray_intersection/ray_distance_1                    [   5.5 ns ...   5.5 ns ]      -0.15%
ray_intersection/ray_distance_5                    [   9.6 ns ...   9.7 ns ]      +0.23%
ray_intersection/ray_distance_20                   [   9.5 ns ...   9.5 ns ]      +0.11%
overlap/no_overlap                                 [  30.9 ns ...  30.2 ns ]      -2.33%
overlap/partial_overlap                            [  31.1 ns ...  31.1 ns ]      +0.21%
overlap/full_containment                           [  22.9 ns ...  22.8 ns ]      -0.07%
point_containment/inside                           [   5.9 ns ...   5.9 ns ]      +0.33%
point_containment/outside                          [   5.4 ns ...   5.4 ns ]      +0.11%
point_containment/boundary                         [   5.8 ns ...   5.8 ns ]      -0.22%

Comparing to 5e4648a

@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 22.96%. Comparing base (9d60273) to head (8f0cef5).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
events/tag/src/module/attack.rs 0.00% 21 Missing ⚠️
events/tag/src/module/spawn.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
- Coverage   22.96%   22.96%   -0.01%     
==========================================
  Files         159      159              
  Lines       16649    16651       +2     
  Branches      469      469              
==========================================
  Hits         3824     3824              
- Misses      12727    12729       +2     
  Partials       98       98              
Files with missing lines Coverage Δ
events/tag/src/module/spawn.rs 0.00% <0.00%> (ø)
events/tag/src/module/attack.rs 0.00% <0.00%> (ø)

@andrewgazelka andrewgazelka added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit a73f3e0 Jan 22, 2025
11 checks passed
@andrewgazelka andrewgazelka deleted the fix-respawn-no-teammates branch January 22, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants