Skip to content

Conversation

@TestingPlant
Copy link
Collaborator

Without this, the code would panic. This can be triggered by shooting an arrow directly up.

Without this, the code would panic. This can be triggered by shooting an
arrow directly up.
@github-actions github-actions bot added the fix label Jan 22, 2025
@github-actions
Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  24.1 ns ...  24.0 ns ]      -0.42%
ray_intersection/aabb_size_1                       [  24.0 ns ...  24.0 ns ]      -0.34%
ray_intersection/aabb_size_10                      [  23.3 ns ...  23.3 ns ]      -0.09%
ray_intersection/ray_distance_1                    [   5.3 ns ...   5.3 ns ]      -0.09%
ray_intersection/ray_distance_5                    [   9.4 ns ...   9.4 ns ]      -0.26%
ray_intersection/ray_distance_20                   [   9.4 ns ...   9.4 ns ]      +0.31%
overlap/no_overlap                                 [  31.1 ns ...  30.2 ns ]      -2.77%
overlap/partial_overlap                            [  30.2 ns ...  31.0 ns ]      +2.90%
overlap/full_containment                           [  22.9 ns ...  22.8 ns ]      -0.25%
point_containment/inside                           [   5.9 ns ...   5.9 ns ]      +0.05%
point_containment/outside                          [   5.3 ns ...   5.3 ns ]      -0.02%
point_containment/boundary                         [   5.8 ns ...   5.8 ns ]      +0.08%

Comparing to 5e4648a

@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 22.96%. Comparing base (5e4648a) to head (6b5f60f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/hyperion/src/simulation/blocks/mod.rs 0.00% 4 Missing ⚠️
@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
- Coverage   22.96%   22.96%   -0.01%     
==========================================
  Files         159      159              
  Lines       16649    16653       +4     
  Branches      469      470       +1     
==========================================
  Hits         3824     3824              
- Misses      12727    12731       +4     
  Partials       98       98              
Files with missing lines Coverage Δ
crates/hyperion/src/simulation/blocks/mod.rs 21.90% <0.00%> (-0.32%) ⬇️

@andrewgazelka andrewgazelka added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 57f5652 Jan 22, 2025
11 checks passed
@andrewgazelka andrewgazelka deleted the fix-above-height-limit branch January 22, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants